Hi Diana, I love your patch! Perhaps something to improve:
[auto build test WARNING on vfio/next] [also build test WARNING on linux/master linus/master v5.9-rc7 next-20200929] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Diana-Craciun/vfio-fsl-mc-VFIO-support-for-FSL-MC-device/20200929-170752 base: https://github.com/awilliam/linux-vfio.git next config: powerpc-allyesconfig (attached as .config) compiler: powerpc64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/2efbc8ba7e0dcd6dc33365f917d29c15ae0fc29a git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Diana-Craciun/vfio-fsl-mc-VFIO-support-for-FSL-MC-device/20200929-170752 git checkout 2efbc8ba7e0dcd6dc33365f917d29c15ae0fc29a # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All warnings (new ones prefixed by >>): >> drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c:16:5: warning: no previous prototype >> for 'vfio_fsl_mc_irqs_allocate' [-Wmissing-prototypes] 16 | int vfio_fsl_mc_irqs_allocate(struct vfio_fsl_mc_device *vdev) | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c: In function 'vfio_fsl_mc_set_irq_trigger': drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c:121:8: error: implicit declaration of function 'fsl_mc_populate_irq_pool' [-Werror=implicit-function-declaration] 121 | ret = fsl_mc_populate_irq_pool(mc_cont, | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c:122:4: error: 'FSL_MC_IRQ_POOL_MAX_TOTAL_IRQS' undeclared (first use in this function) 122 | FSL_MC_IRQ_POOL_MAX_TOTAL_IRQS); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c:122:4: note: each undeclared identifier is reported only once for each function it appears in cc1: some warnings being treated as errors vim +/vfio_fsl_mc_irqs_allocate +16 drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c 15 > 16 int vfio_fsl_mc_irqs_allocate(struct vfio_fsl_mc_device *vdev) 17 { 18 struct fsl_mc_device *mc_dev = vdev->mc_dev; 19 struct vfio_fsl_mc_irq *mc_irq; 20 int irq_count; 21 int ret, i; 22 23 /* Device does not support any interrupt */ 24 if (mc_dev->obj_desc.irq_count == 0) 25 return 0; 26 27 /* interrupts were already allocated for this device */ 28 if (vdev->mc_irqs) 29 return 0; 30 31 irq_count = mc_dev->obj_desc.irq_count; 32 33 mc_irq = kcalloc(irq_count, sizeof(*mc_irq), GFP_KERNEL); 34 if (!mc_irq) 35 return -ENOMEM; 36 37 /* Allocate IRQs */ 38 ret = fsl_mc_allocate_irqs(mc_dev); 39 if (ret) { 40 kfree(mc_irq); 41 return ret; 42 } 43 44 for (i = 0; i < irq_count; i++) { 45 mc_irq[i].count = 1; 46 mc_irq[i].flags = VFIO_IRQ_INFO_EVENTFD; 47 } 48 49 vdev->mc_irqs = mc_irq; 50 51 return 0; 52 } 53 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
