Re: [PATCH v3 04/18] dmaengine: idxd: add interrupt handle request support

[Thomas Gleixner]

On Tue, Sep 15 2020 at 16:28, Dave Jiang wrote:
>  
> +#define INT_HANDLE_IMS_TABLE 0x10000
> +int idxd_device_request_int_handle(struct idxd_device *idxd, int idx,
> +                                int *handle, enum idxd_interrupt_type 
> irq_type)

New lines exist for a reason and this glued together define and function
definition is unreadable garbage.

Also is that magic bit a software flag or defined by hardware? If the
latter then you want to move it to the other hardware defines.

Thanks,

        tglx