> On Oct 5, 2020, at 9:45 AM, [email protected] wrote:
>
> From: Tom Rix <[email protected]>
>
> clang static analysis reports this problem:
>
> qla_nx2.c:694:3: warning: 6th function call argument is
> an uninitialized value
> ql_log(ql_log_fatal, vha, 0xb090,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> In qla8044_poll_reg(), when reading the reg fails, the
> error is reported by reusing the timeout error reporter.
> Because the value is unset, a garbage value will be
> reported. So initialize the value.
>
> Signed-off-by: Tom Rix <[email protected]>
> ---
> drivers/scsi/qla2xxx/qla_nx2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_nx2.c b/drivers/scsi/qla2xxx/qla_nx2.c
> index 3a415b12dcec..01ccd4526707 100644
> --- a/drivers/scsi/qla2xxx/qla_nx2.c
> +++ b/drivers/scsi/qla2xxx/qla_nx2.c
> @@ -659,7 +659,7 @@ static int
> qla8044_poll_reg(struct scsi_qla_host *vha, uint32_t addr,
> int duration, uint32_t test_mask, uint32_t test_result)
> {
> - uint32_t value;
> + uint32_t value = 0;
> int timeout_error;
> uint8_t retries;
> int ret_val = QLA_SUCCESS;
> --
> 2.18.1
>
Reviewed-by: Himanshu Madhani <[email protected]>
--
Himanshu Madhani Oracle Linux Engineering
