On Wed, 21 Nov 2007 14:03:34 +0800 "Dave Young" <[EMAIL PROTECTED]> wrote: > On Nov 21, 2007 2:00 PM, Andrew Morton <[EMAIL PROTECTED]> wrote: > > On Wed, 21 Nov 2007 13:51:47 +0800 "Dave Young" <[EMAIL PROTECTED]> wrote: > > > > > Hi, andrew > > > > > > modpost failed for me: > > > MODPOST 360 modules > > > ERROR: "empty_zero_page" [drivers/kvm/kvm.ko] undefined! > > > make[1]: *** [__modpost] Error 1 > > > make: *** [modules] Error 2 > > > > > > > You're a victim of the hasty unexporting fad. Which architecture? > > x86_64 I guess?
> ia32 instead. FYI, x86_64 has the exact same issue. ---- KVM needs the empty_zero_page export reinstated. Signed-off-by: Rik van Riel <[EMAIL PROTECTED]> diff -up linux-2.6.24-rc3-mm1/arch/x86/kernel/x8664_ksyms_64.c.export-empty-zero-page linux-2.6.24-rc3-mm1/arch/x86/kernel/x8664_ksyms_64.c --- linux-2.6.24-rc3-mm1/arch/x86/kernel/x8664_ksyms_64.c.export-empty-zero-page 2007-11-26 13:47:53.000000000 -0500 +++ linux-2.6.24-rc3-mm1/arch/x86/kernel/x8664_ksyms_64.c 2007-11-26 13:41:32.000000000 -0500 @@ -33,6 +33,7 @@ EXPORT_SYMBOL(__copy_from_user_inatomic) EXPORT_SYMBOL(copy_page); EXPORT_SYMBOL(clear_page); +EXPORT_SYMBOL(empty_zero_page); /* Export string functions. We normally rely on gcc builtin for most of these, but gcc sometimes decides not to inline them. */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/