On Fri, Oct 09, 2020 at 05:30:28PM +0200, Nicolas Saenz Julienne wrote: > The PWM bus controlling the fan in RPi's official PoE hat can only be > controlled by the board's co-processor. > > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulie...@suse.de> > --- > .../arm/bcm/raspberrypi,bcm2835-firmware.yaml | 21 +++++++++++++++++++ > .../pwm/raspberrypi,firmware-pwm.h | 13 ++++++++++++ > 2 files changed, 34 insertions(+) > create mode 100644 include/dt-bindings/pwm/raspberrypi,firmware-pwm.h > > diff --git > a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml > b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml > index a2c63c8b1d10..dcaf00e8602e 100644 > --- > a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml > +++ > b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml > @@ -64,6 +64,22 @@ properties: > - compatible > - "#reset-cells" > > + pwm: > + type: object > + > + properties: > + compatible: > + const: raspberrypi,firmware-pwm > + > + "#pwm-cells": > + const: 1 > + description: > > + The argument is the PWM bus number.
This is wrong. #pwm-cells specifies the number of "arguments" for phandles pointing to this node. And I would prefer this being 2 to match the stuff described in the generic pwm binding. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
signature.asc
Description: PGP signature
