Hi,
On 12/10/20 06:39, Juri Lelli wrote:
> Commit 765cc3a4b224e ("sched/core: Optimize sched_feat() for
> !CONFIG_SCHED_DEBUG builds") made sched features static for
> !CONFIG_SCHED_DEBUG configurations, but overlooked the CONFIG_
> SCHED_DEBUG enabled and !HAVE_JUMP_LABEL cases. For the latter, echoing
> changes to /sys/kernel/debug/sched_features has the nasty effect of
> effectively changing what sched_features reports, but without actually
> changing the scheduler behaviour (since different translation units get
> different sysctl_sched_features).
>
> Fix CONFIG_SCHED_DEBUG and !HAVE_JUMP_LABEL configurations by properly
> restructuring ifdefs.
>
That should be CONFIG_JUMP_LABEL, no? The HAVE stuff should've died with
e9666d10a567 ("jump_label: move 'asm goto' support test to Kconfig")
> Fixes: 765cc3a4b224e ("sched/core: Optimize sched_feat() for
> !CONFIG_SCHED_DEBUG builds")
> Co-developed-by: Daniel Bristot de Oliveira <[email protected]>
> Signed-off-by: Daniel Bristot de Oliveira <[email protected]>
> Signed-off-by: Juri Lelli <[email protected]>
With the aforementioned replacement (changelog AND diff):
Reviewed-by: Valentin Schneider <[email protected]>
