Hi Sanjay, I love your patch! Perhaps something to improve:
[auto build test WARNING on vkoul-dmaengine/next] [also build test WARNING on linus/master sparc-next/master v5.9] [cannot apply to next-20201012] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Sanjay-R-Mehta/Add-support-for-AMD-PTDMA-controller-driver/20201012-192126 base: https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next config: x86_64-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/e3ffc3c5008e1a3bdce62cd71ecbf0cd5ca8de21 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Sanjay-R-Mehta/Add-support-for-AMD-PTDMA-controller-driver/20201012-192126 git checkout e3ffc3c5008e1a3bdce62cd71ecbf0cd5ca8de21 # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All warnings (new ones prefixed by >>): drivers/dma/ptdma/ptdma-dmaengine.c: In function 'pt_do_cleanup': >> drivers/dma/ptdma/ptdma-dmaengine.c:62:22: warning: variable 'chan' set but >> not used [-Wunused-but-set-variable] 62 | struct pt_dma_chan *chan; | ^~~~ drivers/dma/ptdma/ptdma-dmaengine.c: In function 'pt_dmaengine_register': >> drivers/dma/ptdma/ptdma-dmaengine.c:470:19: warning: variable 'dma_chan' set >> but not used [-Wunused-but-set-variable] 470 | struct dma_chan *dma_chan; | ^~~~~~~~ vim +/chan +62 drivers/dma/ptdma/ptdma-dmaengine.c 56 57 static void pt_do_cleanup(struct virt_dma_desc *vd) 58 { 59 struct pt_dma_desc *desc = to_pt_desc(vd); 60 struct pt_device *pt = desc->pt; 61 struct dma_chan *dma_chan; > 62 struct pt_dma_chan *chan; 63 64 dma_chan = desc->vd.tx.chan; 65 chan = to_pt_chan(dma_chan); 66 67 pt_free_cmd_resources(pt, &desc->cmdlist); 68 kmem_cache_free(pt->dma_desc_cache, desc); 69 } 70 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip