On Tue, 2007-11-27 at 10:26 +0800, WANG Cong wrote: > > @@ -414,7 +418,7 @@ int sparse_add_one_section(struct zone * > out: > pgdat_resize_unlock(pgdat, &flags); > if (ret <= 0) > - __kfree_section_memmap(memmap, nr_pages); > + kfree(usemap); > return ret; > } > #endif
Why did you get rid of the memmap free here? A bad return from sparse_init_one_section() indicates that we didn't use the memmap, so it will leak otherwise. -- Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
