Hi folks, I've updated the lock documentation according to our finding for transaction_t. Does this patch look good to you?
Cheers, Alex
commit 13ac907c45c5da7d691f6e10972de5e56e0072c6 Author: Alexander Lochmann <[email protected]> Date: Thu Oct 15 15:24:52 2020 +0200 Updated locking documentation for transaction_t We used LockDoc to derive locking rules for each member of struct transaction_t. Based on those results, we extended the existing documentation by more members of struct transaction_t, and updated the existing documentation. Signed-off-by: Alexander Lochmann <[email protected]> Signed-off-by: Horst Schirmeier <[email protected]> diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h index 08f904943ab2..a11c78e4af4e 100644 --- a/include/linux/jbd2.h +++ b/include/linux/jbd2.h @@ -532,6 +532,7 @@ struct transaction_chp_stats_s { * The transaction keeps track of all of the buffers modified by a * running transaction, and all of the buffers committed but not yet * flushed to home for finished transactions. + * (Locking Documentation improved by LockDoc) */ /* @@ -650,12 +651,12 @@ struct transaction_s unsigned long t_start; /* - * When commit was requested + * When commit was requested [journal_t.j_state_lock] */ unsigned long t_requested; /* - * Checkpointing stats [j_checkpoint_sem] + * Checkpointing stats [journal_t.j_list_lock] */ struct transaction_chp_stats_s t_chp_stats;
signature.asc
Description: OpenPGP digital signature
