> Why include a + character here? > Hi, I tried it without + first, but then lines like "The the repeated word." didn't register a warning.
I think checkpatch adds a + to the line when used on files. Am not sure but my $rawline was: +The the repeated word. > Please use "next if (test);" to be similar to the other uses above. > > And this doesn't work on end of phrase or sentence. > > ie: "my sentence is is, a duplicate word word." > > so $end_char could be a comma or a period. > > so likely the $end_char test should be !~ > I tried on "my sentence is is, a duplicate word word.", and got the following: WARNING: Possible repeated word: 'is' #8: FILE: MAINTAINERS:8: +my sentence is is, a duplicate word word. WARNING: Possible repeated word: 'word' #8: FILE: MAINTAINERS:8: +my sentence is is, a duplicate word word. Am I doing something wrong? > What is the reason to add and use $exclude_chars? > I am comparing both start_char and end_char to find whether they have the characters which will exclude them from repeated word check. So i am keeping the common variable to match from. I thought I would do that so that more exceptions could be added later on easily. I might be wrong in doing that. What do you think? Thanks, Dwaipayan.
