On Wed, 2020-10-21 at 08:28 -0700, Joe Perches wrote: > On Wed, 2020-10-21 at 08:18 -0700, Joe Perches wrote: > > I might add that check to the line below where > > the repeated words are checked against long > [] > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > [] > > @@ -3062,6 +3062,7 @@ sub process { > > > > next if ($first ne $second); > > next if ($first eq 'long'); > > + next if ($first =~ /^$Hex$/; > > oops. with a close parenthesis added of course...
That doesn't work as $Hex expects a leading 0x. But this does... The negative of this approach is it would also not emit a warning on these repeated words: (doesn't seem too bad) $ grep -P '^[0-9a-f]{2,}$' /usr/share/dict/words abed accede acceded ace aced ad add added baa baaed babe bad bade be bead beaded bed bedded bee beef beefed cab cabbed cad cede ceded dab dabbed dad dead deaf deb decade decaf deed deeded deface defaced ebb ebbed efface effaced fa facade face faced fad fade faded fed fee feed --- scripts/checkpatch.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index fab38b493cef..79d7a4cba19e 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3062,6 +3062,7 @@ sub process { next if ($first ne $second); next if ($first eq 'long'); + next if ($first =~ /^[0-9a-f]+$/i); if (WARN("REPEATED_WORD", "Possible repeated word: '$first'\n" . $herecurr) &&