> kernel.h has become a bit disorganized over a long time. > Here's an attempt to clean it up a bit. > > Something for everyone to like or dislike...
You duplicate ALIGN macros all over the place. > Groups externs and functions by module/function > Creates a "logging.h" for printk, KERN_<level> > Changes some macros to statement expressions > DIV_ROUND_UP, roundup and __ALIGN_MASK > Removes the unused PTR_ALIGN > This one used the ALIGN macro, but I'm not inclined to > figure out what it actually does right now, so copy > the old macro to this file and renames it. Which is not acceptable. Ditto for DIV_ROUND_UP. And you somehow decided that putting statements on one line is more readable than on multiple lines -- typecheck and friends. Overall impression -- moving code just because you can. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
