From: Julia Lawall <[EMAIL PROTECTED]> There should be an of_node_put when breaking out of a loop that iterates using for_each_compatible_node.
This was detected and fixed using the following semantic patch. (http://www.emn.fr/x-info/coccinelle/) // <smpl> @@ identifier d; type T; expression e; iterator for_each_compatible_node; @@ T *d; ... for_each_compatible_node(d,...) {... when != of_node_put(d) when != e = d ( return d; | + of_node_put(d); ? return ...; ) ...} // </smpl> Signed-off-by: Julia Lawall <[EMAIL PROTECTED]> --- diff -u -p a/drivers/serial/uartlite.c b/drivers/serial/uartlite.c --- a/drivers/serial/uartlite.c 2007-11-12 10:35:57.000000000 +0100 +++ b/drivers/serial/uartlite.c 2007-12-02 17:43:57.000000000 +0100 @@ -393,6 +393,7 @@ static inline void __init ulite_console_ continue; ulite_ports[id].mapbase = res.start; + of_node_put(np); return; } } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
