> On Oct 30, 2020, at 11:52 AM, Andy Shevchenko
> <[email protected]> wrote:
>
> On Fri, Oct 30, 2020 at 08:55:01AM -0700, [email protected] wrote:
>> From: John Donnelly <[email protected]>
>>
>> The assignment statement of a local variable "struct tp_nvram_state s[2] =
>> {0};
>> is not valid for all versions of compilers.
>
> I don't get the subject. IS it backport of existing change to v4.14, or you
> are
> trying to fix v4.14? If the latter is the case, it's not correct order. Try
> latest vanilla first (v5.10-rc1 as of today) and if there is still an issue,
> submit a patch.
Hi,
It is only intended for 4.14. Why would you back port a commit to a stable
tree that emits warnings ?
>
>> Fixes: 515ded02bc4b ("platform/x86: thinkpad_acpi: initialize tp_nvram_state
>> variable")
>>
>> Signed-off-by: John Donnelly <[email protected]>
>
> Should not be blank line in between.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
