On Mon, 3 Dec 2007, Greg KH wrote: > > Did you want to add an extra kobject_put() to the end of kobject_del()? > > Or did you want to define a new kobject_destroy() that combines calls > > to kobject_del() and kobject_put()? > > No, let's keep what we have there on the cleanup path for now. I have > enough work to clean up the initializion part of the api for now :)
> +/** > + * kobject_add_ng - the main kobject add function > + * @kobj: the kobject to add > + * @parent: pointer to the parent of the kobject. > + * @fmt: format to name the kobject with. > + * > + * The kobject name is set and added to the kobject hierarchy in this > + * function. > + * > + * If @parent is set, then the parent of the @kobj will be set to it. > + * If @parent is NULL, then the parent of the @kobj will be set to the > + * kobject associted with the kset assigned to this kobject. If no kset > + * is assigned to the kobject, then the kobject will be located in the > + * root of the sysfs tree. > + * > + * If this function returns an error, kobject_put() must be called to > + * properly clean up the memory associated with the object. > + * > + * If the function is successful, the only way to properly clean up the > + * memory is with a call to kobject_del(), in which case, a call to > + * kobject_put() is not necessary (kobject_del() does the final > + * kobject_put() to call the release function in the ktype's release > + * pointer.) This comment is inconsistent with your decision above not to add an extra kobject_put() into kobject_del(). (Unless such a line was added while I wasn't looking...) Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/