On 20/10/2020 17:53, Ian Rogers wrote:
Thanks for taking a look John. If you want help you can send the output of "perf test 67 -vvv" to me. It is possible Broadwell has similar glitches in the json to Skylake. I tested the original test on server parts as I can access them as cloud machines.I will have a look, but I was hoping that Ian would have a proper fix for this on top of ("perf metricgroup: Fix uncore metric expressions"), which now looks to be merged.I still have these changes to look at in my inbox but I'm assuming they're good:-) Sorry for not getting to them, but it's good they are merged.Hi Ian, Checked in upstream kernel with your fix patch, in powerpc also test case 67 is passing. But I am getting issue in test 10 for powerpc [command]# ./perf test 10 10: PMU events : 10.1: PMU event table sanity : Ok 10.2: PMU event map aliases : Ok 10.3: Parsing of PMU event table metrics : Skip (some metrics failed) 10.4: Parsing of PMU event table metrics with fake PMUs : FAILED! Was debugging it, issue is with commit e1c92a7fbbc5 perf tests: Add another metric parsing test. So, there we are passing different runtime parameter value in "expr__find_other and expr__parse" in function `metric_parse_fake`. I believe we need to send same value. I will send fix patch for the same.
Just wondering, was a patch ever submitted for this? Something still broken? I can't see any recent relevant changes to tests/pmu-events.c
Thanks, John
