On Tue, Nov 03, 2020 at 05:29:28PM -0800, Douglas Anderson wrote:
> This adds new bindings for the Goodix GT7375P touchscreen. While this
> touchscreen's communications are based on the generic "i2c-over-hid"
> protocol, it needs special power sequencing and thus gets its own
> compatible and bindings.
'dt-bindings: input: ...' for the subject.
>
> Signed-off-by: Douglas Anderson <diand...@chromium.org>
> ---
>
> (no changes since v3)
>
> Changes in v3:
> - Removed Benjamin as a maintainer.
> - Fixed compatible in example.
> - Updated description.
>
> Changes in v2:
> - ("dt-bindings: HID: i2c-hid: Introduce bindings for the Goodix GT7375P")
> new in v2.
>
> .../bindings/input/goodix,gt7375p.yaml | 63 +++++++++++++++++++
> 1 file changed, 63 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
>
> diff --git a/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
> b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
> new file mode 100644
> index 000000000000..15a38516e594
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/goodix,gt7375p.yaml
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/goodix,gt7375p.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Goodix GT7375P touchscreen
> +
> +maintainers:
> + - Douglas Anderson <diand...@chromium.org>
> +
> +description:
> + Supports the Goodix GT7375P touchscreen.
Perhaps mention hid over i2c here given that's only captured in the
commit message.
With those nits addressed.
Reviewed-by: Rob Herring <r...@kernel.org>
> +
> +properties:
> + compatible:
> + items:
> + - const: goodix,gt7375p
> +
> + reg:
> + enum:
> + - 0x5d
> + - 0x14
> +
> + interrupts:
> + maxItems: 1
> +
> + reset-gpios:
> + true
> +
> + vdd-supply:
> + description: The 3.3V supply to the touchscreen.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - reset-gpios
> + - vdd-supply
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/qcom,rpmh.h>
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + ap_ts: touchscreen@5d {
> + compatible = "goodix,gt7375p";
> + reg = <0x5d>;
> +
> + interrupt-parent = <&tlmm>;
> + interrupts = <9 IRQ_TYPE_LEVEL_LOW>;
> +
> + reset-gpios = <&tlmm 8 GPIO_ACTIVE_LOW>;
> + vdd-supply = <&pp3300_ts>;
> + };
> + };
> --
> 2.29.1.341.ge80a0c044ae-goog
>
