On Mon, 9 Nov 2020 15:00:02 +0100 Michal Kubecek wrote: > On Sun, Nov 08, 2020 at 12:46:15AM +0000, Alexander Lobakin wrote: > > After updating userspace Ethtool from 5.7 to 5.9, I noticed that > > NETDEV_FEAT_CHANGE is no more raised when changing netdev features > > through Ethtool. > > That's because the old Ethtool ioctl interface always calls > > netdev_features_change() at the end of user request processing to > > inform the kernel that our netdevice has some features changed, but > > the new Netlink interface does not. Instead, it just notifies itself > > with ETHTOOL_MSG_FEATURES_NTF. > > Replace this ethtool_notify() call with netdev_features_change(), so > > the kernel will be aware of any features changes, just like in case > > with the ioctl interface. This does not omit Ethtool notifications, > > as Ethtool itself listens to NETDEV_FEAT_CHANGE and drops > > ETHTOOL_MSG_FEATURES_NTF on it > > (net/ethtool/netlink.c:ethnl_netdev_event()). > > > > From v1 [1]: > > - dropped extra new line as advised by Jakub; > > - no functional changes. > > > > [1] > > https://lore.kernel.org/netdev/alzxq2o5uutvhcfngoiggj8vj3kgo5yiwanqjh0...@cp3-web-009.plabs.ch > > > > Fixes: 0980bfcd6954 ("ethtool: set netdev features with FEATURES_SET > > request") > > Signed-off-by: Alexander Lobakin <aloba...@pm.me> > > Reviewed-by: Michal Kubecek <mkube...@suse.cz>
Applied, thanks!