On 2020/11/10 2:12, Eric Biggers wrote:
On Mon, Nov 09, 2020 at 10:29:25AM +0800, Chao Yu wrote:
Oh I see, the cp-related checks are at the beginning of f2fs_ioctl() too.
In that case a much better approach would be to add __f2fs_ioctl() which is
called by f2fs_ioctl() and f2fs_compat_ioctl(), and have f2fs_ioctl() and
f2fs_compat_ioctl() do the cp-related checks but not __f2fs_ioctl().
Will this cleanup make sense to you?
I think it would be better to do it the way I suggested.
Updated in v5.
Thanks,
- Eric
.
