> -----Original Message----- > From: Lee Jones [mailto:[email protected]] > Sent: 2020年11月12日 19:02 > To: [email protected] > Cc: [email protected]; Dmitry Torokhov > <[email protected]>; Shawn Guo <[email protected]>; Sascha > Hauer <[email protected]>; Pengutronix Kernel Team > <[email protected]>; Fabio Estevam <[email protected]>; > dl-linux-imx <[email protected]>; Haibo Chen <[email protected]>; > [email protected] > Subject: [PATCH 05/15] input: touchscreen: imx6ul_tsc: Remove set but unused > variable 'value' > > Fixes the following W=1 kernel build warning(s): > > drivers/input/touchscreen/imx6ul_tsc.c: In function ‘adc_irq_fn’: > drivers/input/touchscreen/imx6ul_tsc.c:307:6: warning: variable ‘value’ set > but not used [-Wunused-but-set-variable] > > Cc: Dmitry Torokhov <[email protected]> > Cc: Shawn Guo <[email protected]> > Cc: Sascha Hauer <[email protected]> > Cc: Pengutronix Kernel Team <[email protected]> > Cc: Fabio Estevam <[email protected]> > Cc: NXP Linux Team <[email protected]> > Cc: Haibo Chen <[email protected]> > Cc: [email protected] > Signed-off-by: Lee Jones <[email protected]> > --- > drivers/input/touchscreen/imx6ul_tsc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/input/touchscreen/imx6ul_tsc.c > b/drivers/input/touchscreen/imx6ul_tsc.c > index cd369f9ac5e60..e1852f7d4d31e 100644 > --- a/drivers/input/touchscreen/imx6ul_tsc.c > +++ b/drivers/input/touchscreen/imx6ul_tsc.c > @@ -304,11 +304,10 @@ static irqreturn_t adc_irq_fn(int irq, void *dev_id) > { > struct imx6ul_tsc *tsc = dev_id; > u32 coco; > - u32 value; > > coco = readl(tsc->adc_regs + REG_ADC_HS); > if (coco & 0x01) { > - value = readl(tsc->adc_regs + REG_ADC_R0); > + readl(tsc->adc_regs + REG_ADC_R0); > complete(&tsc->completion); > } >
Reviewed-by: Haibo Chen <[email protected]> > -- > 2.25.1
