On Fri, Nov 13, 2020 at 3:46 AM Andrew Morton <[email protected]> wrote: > > On Fri, 13 Nov 2020 02:38:18 +0100 Matteo Croce <[email protected]> > wrote: > > > At this point, since 'pci' enables BOOT_CF9_FORCE type and > > BOOT_CF9_SAFE is not user selectable, should I simply leave only > > 'pci'? > > This way, we'll have the same set of options for both sysfs and kernel > > cmdline. > > Well, you're the reboot expert ;) >
So honored! :) > But my $0.02 is yes, let's keep the command-line and sysfs interfaces > in sync and cover it all in documentation. It would of course be > problematic to change the existing reboot= interface. > > I assume that means doing this? > > - #define BOOT_CF9_FORCE_STR "cf9_force" > + #define BOOT_CF9_FORCE_STR "pci" > - #define BOOT_CF9_SAFE_STR "cf9_safe" Either BOOT_PCI_STR or BOOT_CF9_FORCE_STR, I have no strong preference. The syntax is 'pci' while the enum BOOT_CF9_FORCE, so we can't please both. Regards, -- per aspera ad upstream
