On 11/12/20 10:06 AM, [email protected] wrote: > From: Richard Gong <[email protected]> > > Add FPGA_MGR_BITSTREM_AUTHENTICATION flag for FPGA bitstream > authentication.
Should improve this commit so explain what you mean authentication. it could mean 'it wrote correctly' or 'it was signed correctly' or something else. > > Signed-off-by: Richard Gong <[email protected]> > --- > include/linux/fpga/fpga-mgr.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/linux/fpga/fpga-mgr.h b/include/linux/fpga/fpga-mgr.h > index 2bc3030..1d65814 100644 > --- a/include/linux/fpga/fpga-mgr.h > +++ b/include/linux/fpga/fpga-mgr.h > @@ -67,12 +67,15 @@ enum fpga_mgr_states { > * %FPGA_MGR_BITSTREAM_LSB_FIRST: SPI bitstream bit order is LSB first > * > * %FPGA_MGR_COMPRESSED_BITSTREAM: FPGA bitstream is compressed > + * > + * %FPGA_MGR_BITSTREM_AUTHENTICATION: do FPGA bitstream authentication > */ > #define FPGA_MGR_PARTIAL_RECONFIG BIT(0) > #define FPGA_MGR_EXTERNAL_CONFIG BIT(1) > #define FPGA_MGR_ENCRYPTED_BITSTREAM BIT(2) > #define FPGA_MGR_BITSTREAM_LSB_FIRST BIT(3) > #define FPGA_MGR_COMPRESSED_BITSTREAM BIT(4) > +#define FPGA_MGR_BITSTREM_AUTHENTICATION BIT(5) A whitespace issue, the new BIT(5) should align with the others, so add two spaces to the others. Tom > > /** > * struct fpga_image_info - information specific to a FPGA image
