On Wed, Nov 18, 2020 at 09:46:15AM -0500, Willem de Bruijn wrote:
> -static inline struct timespec64 ep_set_mstimeout(long ms)
> +static inline struct timespec64 ep_set_nstimeout(s64 timeout)
>  {
> -     struct timespec64 now, ts = {
> -             .tv_sec = ms / MSEC_PER_SEC,
> -             .tv_nsec = NSEC_PER_MSEC * (ms % MSEC_PER_SEC),
> -     };
> +     struct timespec64 now, ts;
>  
> +     ts = ns_to_timespec64(timeout);
>       ktime_get_ts64(&now);
>       return timespec64_add_safe(now, ts);
>  }

Why do you pass around an s64 for timeout, converting it to and from
a timespec64 instead of passing around a timespec64?

Reply via email to