On Thu, 19 Nov 2020 10:53:23 -0800 Edwin Peer wrote:
> > Fix to return a negative error code from the error handling
> > case instead of 0, as done elsewhere in this function.
> >
> > Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.")
> > Reported-by: Hulk Robot <[email protected]>
> > Signed-off-by: Zhang Changzhong <[email protected]>
> > if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)) != 0 &&
> > dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)) != 0) {
> > dev_err(&pdev->dev, "System does not support DMA,
> > aborting\n");
> > + rc = -EIO;
> > goto init_err_disable;
Edwin, please double check if this shouldn't jump to
pci_release_regions() (or maybe it's harmless 'cause
PCI likes to magically release things on its own).
> > }
>
> Reviewed-by: Edwin Peer <[email protected]>
Applied thanks!
