On Thu, Nov 19, 2020 at 10:49 PM Paul E. McKenney <paul...@kernel.org> wrote:
>
> On Wed, Nov 18, 2020 at 11:53:09AM +0800, qiang.zh...@windriver.com wrote:
> > From: Zqiang <qiang.zh...@windriver.com>
> >
> > Add kasan_record_aux_stack function for kvfree_call_rcu function to
> > record call stacks.
> >
> > Signed-off-by: Zqiang <qiang.zh...@windriver.com>
>
> Thank you, but this does not apply on the "dev" branch of the -rcu tree.
> See file:///home/git/kernel.org/rcutodo.html for more info.
>
> Adding others on CC who might have feedback on the general approach.
>
> Thanx, Paul
>
> > ---
> > kernel/rcu/tree.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> > index da3414522285..a252b2f0208d 100644
> > --- a/kernel/rcu/tree.c
> > +++ b/kernel/rcu/tree.c
> > @@ -3506,7 +3506,7 @@ void kvfree_call_rcu(struct rcu_head *head,
> > rcu_callback_t func)
> > success = true;
> > goto unlock_return;
> > }
> > -
> > + kasan_record_aux_stack(ptr);
> > success = kvfree_call_rcu_add_ptr_to_bulk(krcp, ptr);
> > if (!success) {
> > run_page_cache_worker(krcp);
kvfree_call_rcu is intended to free objects, right? If so this is:
Acked-by: Dmitry Vyukov <dvyu...@google.com>
