On Mon, Nov 23, 2020 at 9:52 AM Oleg Nesterov <[email protected]> wrote:
>
> Can anyone explain why does do_coredump() need unshare_files() at all?
Hmm. It goes back to 2012, and it's placed just before calling
"->core_dump()", so I assume some core dumping function messed with
the file table back when..
I can't see anything like that currently.
The alternative is that core-dumping just keeps the file table around
for a long while, and thus files don't actually close in a timely
manner. So it might not be a "correctness" issue as much as a latency
issue.
Linus
