Re: [PATCH v15 6/9] arm64/kvm: Add hypercall service for kvm ptp.

[Marc Zyngier]

On 2020-11-24 05:20, Jianyong Wu wrote:

Hi Marc,

[...]

> +/* ptp_kvm counter type ID */
> +#define ARM_PTP_VIRT_COUNTER                      0
> +#define ARM_PTP_PHY_COUNTER                       1
> +#define ARM_PTP_NONE_COUNTER                      2

The architecture definitely doesn't have this last counter.

Yeah, this is just represent no counter data needed from guest.
Some annotation should be added here.

I'd rather you remove it entirely, or explain why you really cannot
do without a fake counter.

        M.
--
Jazz is not dead. It just smells funny...