Hi Marc, > -----Original Message----- > From: Marc Zyngier <[email protected]> > Sent: Tuesday, November 24, 2020 5:07 PM > To: Jianyong Wu <[email protected]> > Cc: [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; Mark Rutland <[email protected]>; > [email protected]; Suzuki Poulose <[email protected]>; Andre > Przywara <[email protected]>; Steven Price > <[email protected]>; [email protected]; linux-arm- > [email protected]; [email protected]; > [email protected]; Steve Capper <[email protected]>; Justin He > <[email protected]>; nd <[email protected]> > Subject: Re: [PATCH v15 6/9] arm64/kvm: Add hypercall service for kvm ptp. > > On 2020-11-24 05:20, Jianyong Wu wrote: > > Hi Marc, > > [...] > > >> > +/* ptp_kvm counter type ID */ > >> > +#define ARM_PTP_VIRT_COUNTER 0 > >> > +#define ARM_PTP_PHY_COUNTER 1 > >> > +#define ARM_PTP_NONE_COUNTER 2 > >> > >> The architecture definitely doesn't have this last counter. > > > > Yeah, this is just represent no counter data needed from guest. > > Some annotation should be added here. > > I'd rather you remove it entirely, or explain why you really cannot do without > a fake counter.
OK, I will remove it. Thanks Jianyong > > M. > -- > Jazz is not dead. It just smells funny...
