Please check line 2432. Based on the preceeding tests, there may be a NULL pointer dereference.
julia ---------- Forwarded message ---------- Date: Fri, 27 Nov 2020 06:27:51 +0800 From: kernel test robot <l...@intel.com> To: kbu...@lists.01.org Cc: l...@intel.com, Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH v2 2/5] clk: Add CLK_GET_PARENT_NOCACHE flag CC: kbuild-...@lists.01.org In-Reply-To: <1606394409-12755-3-git-send-email-abel.v...@nxp.com> References: <1606394409-12755-3-git-send-email-abel.v...@nxp.com> TO: Abel Vesa <abel.v...@nxp.com> TO: Stephen Boyd <sb...@kernel.org> TO: Sascha Hauer <ker...@pengutronix.de> TO: Peng Fan <peng....@nxp.com> TO: Fabio Estevam <fabio.este...@nxp.com> TO: Anson Huang <anson.hu...@nxp.com> TO: Dong Aisheng <aisheng.d...@nxp.com> TO: Jacky Bai <ping....@nxp.com> CC: NXP Linux Team <linux-...@nxp.com> CC: linux-...@vger.kernel.org CC: Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Hi Abel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on shawnguo/for-next] [also build test WARNING on clk/clk-next v5.10-rc5 next-20201126] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Abel-Vesa/clk-imx-Register-the-dram_apb-and-dram_alt-as-read-only/20201126-204442 base: https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next :::::: branch date: 10 hours ago :::::: commit date: 10 hours ago config: x86_64-randconfig-c002-20201127 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> Reported-by: Julia Lawall <julia.law...@lip6.fr> "coccinelle warnings: (new ones prefixed by >>)" >> drivers/clk/clk.c:2432:23-29: ERROR: clk -> core is NULL but dereferenced. drivers/clk/clk.c:2432:50-56: ERROR: clk -> core is NULL but dereferenced. vim +2432 drivers/clk/clk.c 05e4e881cde17e7 Abel Vesa 2020-11-26 2413 4dff95dc9477a34 Stephen Boyd 2015-04-30 2414 /** 4dff95dc9477a34 Stephen Boyd 2015-04-30 2415 * clk_get_parent - return the parent of a clk 4dff95dc9477a34 Stephen Boyd 2015-04-30 2416 * @clk: the clk whose parent gets returned 4dff95dc9477a34 Stephen Boyd 2015-04-30 2417 * 4dff95dc9477a34 Stephen Boyd 2015-04-30 2418 * Simply returns clk->parent. Returns NULL if clk is NULL. 4935b22c46ea5e2 James Hogan 2013-07-29 2419 */ 4dff95dc9477a34 Stephen Boyd 2015-04-30 2420 struct clk *clk_get_parent(struct clk *clk) 4dff95dc9477a34 Stephen Boyd 2015-04-30 2421 { 4dff95dc9477a34 Stephen Boyd 2015-04-30 2422 struct clk *parent; da0f0b2c3ad2ad9 Tomasz Figa 2013-09-29 2423 fc4a05d4b0eb1a0 Stephen Boyd 2015-06-25 2424 if (!clk) fc4a05d4b0eb1a0 Stephen Boyd 2015-06-25 2425 return NULL; fc4a05d4b0eb1a0 Stephen Boyd 2015-06-25 2426 4dff95dc9477a34 Stephen Boyd 2015-04-30 2427 clk_prepare_lock(); 05e4e881cde17e7 Abel Vesa 2020-11-26 2428 if (clk->core && (clk->core->flags & CLK_GET_PARENT_NOCACHE)) 05e4e881cde17e7 Abel Vesa 2020-11-26 2429 parent = __clk_get_parent(clk->core)->hw->clk; 05e4e881cde17e7 Abel Vesa 2020-11-26 2430 else fc4a05d4b0eb1a0 Stephen Boyd 2015-06-25 2431 /* TODO: Create a per-user clk and change callers to call clk_put */ fc4a05d4b0eb1a0 Stephen Boyd 2015-06-25 @2432 parent = !clk->core->parent ? NULL : clk->core->parent->hw->clk; 4dff95dc9477a34 Stephen Boyd 2015-04-30 2433 clk_prepare_unlock(); 4935b22c46ea5e2 James Hogan 2013-07-29 2434 4dff95dc9477a34 Stephen Boyd 2015-04-30 2435 return parent; 4935b22c46ea5e2 James Hogan 2013-07-29 2436 } 4dff95dc9477a34 Stephen Boyd 2015-04-30 2437 EXPORT_SYMBOL_GPL(clk_get_parent); 4935b22c46ea5e2 James Hogan 2013-07-29 2438 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
