Hi Stefan, The driver was ported from latest ASPEED BSP, so I only test with ECC-on/off from u-boot and check if driver runs correctly.
The test doc you provided is very nice and detailed, I'll try to reproduce the injection test in v2 patch. Thanks, Troy Lee > -----Original Message----- > From: Stefan Schaeckeler (sschaeck) <[email protected]> > Sent: Monday, November 30, 2020 5:16 PM > To: Troy Lee <[email protected]>; Rob Herring <[email protected]>; > Joel Stanley <[email protected]>; Andrew Jeffery <[email protected]>; Borislav > Petkov <[email protected]>; Mauro Carvalho Chehab <[email protected]>; > Tony Luck <[email protected]>; James Morse <[email protected]>; > Robert Richter <[email protected]>; open list:OPEN FIRMWARE AND > FLATTENED DEVICE TREE BINDINGS <[email protected]>; moderated > list:ARM/ASPEED MACHINE SUPPORT <[email protected]>; > moderated list:ARM/ASPEED MACHINE SUPPORT > <[email protected]>; open list <[email protected]>; > open list:EDAC-CORE <[email protected]> > Cc: [email protected]; Ryan Chen <[email protected]>; Stefan > Schaeckeler <[email protected]> > Subject: Re: [PATCH 3/3] edac: Supporting AST2400 and AST2600 edac driver > > Hello Troy, > > > Adding AST2400 and AST2600 edac driver support. > > > > Signed-off-by: Troy Lee <[email protected]> > > --- > > drivers/edac/Kconfig | 6 +- > > drivers/edac/aspeed_edac.c | 114 +++++++++++++++++++++++++++++-------- > > 2 files changed, 94 insertions(+), 26 deletions(-) > > Uh, there are quite some non-trivial changes. I'll have a look over the coming > weekend. > > Testing an edac driver comes with challenges. Did you test your code? If so, > how? > > That's how I was testing my original edac 2500 driver > http://students.engr.scu.edu/~sschaeck/misc/aspeed-edac.html > > Stefan
