On Thu, 2020-12-03 at 00:00 +0530, Aditya Srivastava wrote:
> Currently, checkpatch.pl warns us for BAD_SIGN_OFF on the usage of
> non-standard signatures.
>
> An evaluation on v4.13..v5.8 showed that out of 539 warnings due to
> non-standard signatures, 43 are due to the use of 'Co-authored-by'
> tag, which may seem correct, but is not standard.
>
> The standard signature equivalent for 'Co-authored-by' is
> 'Co-developed-by'.
I'm not going to ack this as I don't mind non-standard signatures.
You should also always use patch subject versioning and include
a changelog after the --- line.
> Provide a fix by suggesting users with this signature alternative and
> replacing.
>
> Signed-off-by: Aditya Srivastava <yashsri...@gmail.com>
> ---
> scripts/checkpatch.pl | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 4a026926139f..fc036d545d2d 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2832,6 +2832,9 @@ sub process {
>
>
> if ($sign_off !~ /$signature_tags/) {
> my $suggested_signature =
> find_standard_signature($sign_off);
> + if ($sign_off =~ /co-authored-by:/i) {
> + $suggested_signature =
> "Co-developed-by:";
> + }
> if ($suggested_signature eq "") {
> WARN("BAD_SIGN_OFF",
> "Non-standard signature:
> $sign_off\n" . $herecurr);
