> -----Original Message-----
> From: Kishon Vijay Abraham I <kis...@ti.com>
> Sent: Wednesday, November 11, 2020 8:36 AM
> To: Bjorn Helgaas <bhelg...@google.com>; Jonathan Corbet
> <cor...@lwn.net>; Kishon Vijay Abraham I <kis...@ti.com>; Lorenzo
> Pieralisi <lorenzo.pieral...@arm.com>; Arnd Bergmann <a...@arndb.de>;
> Jon Mason <jdma...@kudzu.us>; Jiang, Dave <dave.ji...@intel.com>;
> Allen Hubbe <alle...@gmail.com>; Tom Joseph <tjos...@cadence.com>;
> Rob Herring <r...@kernel.org>
> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>; linux-
> p...@vger.kernel.org; linux-...@vger.kernel.org; linux-
> ker...@vger.kernel.org; linux-...@googlegroups.com
> Subject: [PATCH v8 16/18] NTB: tool: Enable the NTB/PCIe link on the local or
> remote side of bridge
> 
> Invoke ntb_link_enable() to enable the NTB/PCIe link on the local or remote
> side of the bridge.
> 
> Signed-off-by: Kishon Vijay Abraham I <kis...@ti.com>
> ---
>  drivers/ntb/test/ntb_tool.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c index
> b7bf3f863d79..8230ced503e3 100644
> --- a/drivers/ntb/test/ntb_tool.c
> +++ b/drivers/ntb/test/ntb_tool.c
> @@ -1638,6 +1638,7 @@ static int tool_probe(struct ntb_client *self, struct
> ntb_dev *ntb)
> 
>       tool_setup_dbgfs(tc);
> 
> +     ntb_link_enable(ntb, NTB_SPEED_AUTO, NTB_WIDTH_AUTO);

The tool expects the user to enable the link via debugfs according to 
documentation. Is this necessary?

>       return 0;
> 
>  err_clear_mws:
> --
> 2.17.1

Reply via email to