Hi Namhyung and Jiri, > -----Original Message----- > From: Jiri Olsa <jo...@redhat.com> > Sent: Monday, December 7, 2020 10:29 PM > To: Namhyung Kim <namhy...@kernel.org> > Cc: Chanho Park <chanho61.p...@samsung.com>; Will Deacon <w...@kernel.org>; > Chanho Park <parkc...@gmail.com>; mathieu.poir...@linaro.org; > suzuki.poul...@arm.com; coresi...@lists.linaro.org; linux-arm- > ker...@lists.infradead.org; linux-kernel <linux-kernel@vger.kernel.org>; > Mike Leach <mike.le...@linaro.org>; Leo Yan <leo....@linaro.org>; John > Garry <john.ga...@huawei.com>; Peter Zijlstra <pet...@infradead.org>; Ingo > Molnar <mi...@redhat.com>; Arnaldo Carvalho de Melo <a...@kernel.org>; > Mark Rutland <mark.rutl...@arm.com>; Khem Raj <raj.k...@gmail.com> > Subject: Re: [PATCH] perf arm pmu: fix build error on MUSL libc > > On Mon, Dec 07, 2020 at 09:31:06PM +0900, Namhyung Kim wrote: > > Hi Chanho, > > > > On Mon, Dec 7, 2020 at 8:58 PM Chanho Park <chanho61.p...@samsung.com> > wrote: > > > > > > Hi Will, > > > > > > > Looks like other files just include this unconditionally, but have > > > > a comment explaining why. See util/branch.h and util/event.h. > > > > Maybe we should do the same for util/pmu.h, which is already > included here? > > > > > > I found below files which perf includes <linux/perf_event.h>. > > > Instead of doing same for all, we'd better put this only for > > > tools/include/uapi/linux/perf_event.h. > > > > It's a copy of the kernel header, I'm not sure we want to add something > there. > > right, we want to copy that directly from kernel uapi so let's not do any > changes in here >
I tried to modify it from include/uapi/linux/perf_event.h but it didn't work. And then, I found perf tool tried to refer the header from tools/include/ directory. I should go include/uapi first and sync the change to tools/ directory. I'll re-spin this patch. Best Regard, Chanho Park
