Hi Tian, I love your patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next drm-tip/drm-tip linus/master v5.10-rc7 next-20201207] [cannot apply to drm/drm-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Tian-Tao/drm-tidss-Use-the-new-api-devm_drm_irq_install/20201208-155323 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: h8300-randconfig-r016-20201208 (attached as .config) compiler: h8300-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/c31dcdd7b0bbfc11fa4ff1f81164483b478025c4 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Tian-Tao/drm-tidss-Use-the-new-api-devm_drm_irq_install/20201208-155323 git checkout c31dcdd7b0bbfc11fa4ff1f81164483b478025c4 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=h8300 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): drivers/gpu/drm/tidss/tidss_drv.c: In function 'tidss_probe': >> drivers/gpu/drm/tidss/tidss_drv.c:176:8: error: implicit declaration of >> function 'devm_irq_install'; did you mean 'drm_irq_install'? >> [-Werror=implicit-function-declaration] 176 | ret = devm_irq_install(ddev, irq); | ^~~~~~~~~~~~~~~~ | drm_irq_install cc1: some warnings being treated as errors vim +176 drivers/gpu/drm/tidss/tidss_drv.c 162 163 ret = tidss_modeset_init(tidss); 164 if (ret < 0) { 165 if (ret != -EPROBE_DEFER) 166 dev_err(dev, "failed to init DRM/KMS (%d)\n", ret); 167 goto err_runtime_suspend; 168 } 169 170 irq = platform_get_irq(pdev, 0); 171 if (irq < 0) { 172 ret = irq; 173 goto err_runtime_suspend; 174 } 175 > 176 ret = devm_irq_install(ddev, irq); 177 if (ret) { 178 dev_err(dev, "drm_irq_install failed: %d\n", ret); 179 goto err_runtime_suspend; 180 } 181 182 drm_kms_helper_poll_init(ddev); 183 184 drm_mode_config_reset(ddev); 185 186 ret = drm_dev_register(ddev, 0); 187 if (ret) { 188 dev_err(dev, "failed to register DRM device\n"); 189 goto err_irq_uninstall; 190 } 191 192 drm_fbdev_generic_setup(ddev, 32); 193 194 dev_dbg(dev, "%s done\n", __func__); 195 196 return 0; 197 198 err_irq_uninstall: 199 drm_irq_uninstall(ddev); 200 201 err_runtime_suspend: 202 #ifndef CONFIG_PM 203 dispc_runtime_suspend(tidss->dispc); 204 #endif 205 pm_runtime_disable(dev); 206 207 return ret; 208 } 209 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
