On Sat, Dec 15, 2007 at 05:31:30PM +1100, Benjamin Herrenschmidt wrote: > > That's something I've actually never quite liked... the fact that we > evaluate the expression anyway. I'm pretty happy with -not- evaluating > the expression when CONFIG_BUG is on most of the time since whatever is > in there is purely here for the sake of the BUG/WARN test.
Whether we evaluate the expression is a completely different debate. I personally agree with you that expressions that have side-effects are a stupid idea for either WARN_ON or BUG_ON. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
