On Fri, Dec 11, 2020 at 10:28:35AM +0100, Lino Sanfilippo wrote: > Hi Uwe, > > > Gesendet: Donnerstag, 10. Dezember 2020 um 12:43 Uhr > > Von: "Uwe Kleine-König" <[email protected]> > > An: "Lino Sanfilippo" <[email protected]> > > Cc: [email protected], [email protected], [email protected], > > [email protected], [email protected], [email protected], > > [email protected], [email protected], > > [email protected], [email protected], > > [email protected], [email protected] > > Betreff: Re: [PATCH v3] pwm: bcm2835: Support apply function for atomic > > configuration > > > > > Side note: I'm a bit surprised about the output of > > > > b4 diff [email protected] > > > > This is probably due to the fact that compared to v3 you also rebased. > > Still the diff is quite big. > > You are right, I made a rebase before I created the last patch, sorry for the > confusion this caused. > Anyway, thanks for the review(s)!
You did everything good enough. (To further improve, you could use
git-format-patch's --base option and mention a rebase in the series'
changelog; note this is quite high level critic.)
This was more me wondering the output is not easier to use. (And note I
also showed the wrong commandline, but that doesn't resolve the issue.
The right command is:
b4 diff [email protected]
.)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
signature.asc
Description: PGP signature
