Tested on a JZ4740 system (ARCH=mips make qi_lb60_defconfig), this saves
about 14 KiB, by allowing the compiler to garbage-collect all the
functions and tables that correspond to SoCs that were disabled in the
config.

Signed-off-by: Paul Cercueil <p...@crapouillou.net>
---

Notes:
    v2: Drop <linux/if_enabled.h> include

 drivers/pinctrl/pinctrl-ingenic.c | 60 ++++++++++++++++++++++++-------
 1 file changed, 48 insertions(+), 12 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-ingenic.c 
b/drivers/pinctrl/pinctrl-ingenic.c
index a14938a7cc30..cb8fa261110a 100644
--- a/drivers/pinctrl/pinctrl-ingenic.c
+++ b/drivers/pinctrl/pinctrl-ingenic.c
@@ -2384,6 +2384,12 @@ static int __init ingenic_pinctrl_probe(struct 
platform_device *pdev)
        unsigned int i;
        int err;
 
+       chip_info = of_device_get_match_data(dev);
+       if (!chip_info) {
+               dev_err(dev, "Unsupported SoC\n");
+               return -EINVAL;
+       }
+
        jzpc = devm_kzalloc(dev, sizeof(*jzpc), GFP_KERNEL);
        if (!jzpc)
                return -ENOMEM;
@@ -2400,7 +2406,7 @@ static int __init ingenic_pinctrl_probe(struct 
platform_device *pdev)
        }
 
        jzpc->dev = dev;
-       jzpc->info = chip_info = of_device_get_match_data(dev);
+       jzpc->info = chip_info;
 
        pctl_desc = devm_kzalloc(&pdev->dev, sizeof(*pctl_desc), GFP_KERNEL);
        if (!pctl_desc)
@@ -2470,17 +2476,47 @@ static int __init ingenic_pinctrl_probe(struct 
platform_device *pdev)
 }
 
 static const struct of_device_id ingenic_pinctrl_of_match[] = {
-       { .compatible = "ingenic,jz4740-pinctrl", .data = &jz4740_chip_info },
-       { .compatible = "ingenic,jz4725b-pinctrl", .data = &jz4725b_chip_info },
-       { .compatible = "ingenic,jz4760-pinctrl", .data = &jz4760_chip_info },
-       { .compatible = "ingenic,jz4760b-pinctrl", .data = &jz4760_chip_info },
-       { .compatible = "ingenic,jz4770-pinctrl", .data = &jz4770_chip_info },
-       { .compatible = "ingenic,jz4780-pinctrl", .data = &jz4780_chip_info },
-       { .compatible = "ingenic,x1000-pinctrl", .data = &x1000_chip_info },
-       { .compatible = "ingenic,x1000e-pinctrl", .data = &x1000_chip_info },
-       { .compatible = "ingenic,x1500-pinctrl", .data = &x1500_chip_info },
-       { .compatible = "ingenic,x1830-pinctrl", .data = &x1830_chip_info },
-       {},
+       {
+               .compatible = "ingenic,jz4740-pinctrl",
+               .data = IF_ENABLED(CONFIG_MACH_JZ4740, &jz4740_chip_info)
+       },
+       {
+               .compatible = "ingenic,jz4725b-pinctrl",
+               .data = IF_ENABLED(CONFIG_MACH_JZ4725B, &jz4725b_chip_info)
+       },
+       {
+               .compatible = "ingenic,jz4760-pinctrl",
+               .data = IF_ENABLED(CONFIG_MACH_JZ4760, &jz4760_chip_info)
+       },
+       {
+               .compatible = "ingenic,jz4760b-pinctrl",
+               .data = IF_ENABLED(CONFIG_MACH_JZ4760, &jz4760_chip_info)
+       },
+       {
+               .compatible = "ingenic,jz4770-pinctrl",
+               .data = IF_ENABLED(CONFIG_MACH_JZ4770, &jz4770_chip_info)
+       },
+       {
+               .compatible = "ingenic,jz4780-pinctrl",
+               .data = IF_ENABLED(CONFIG_MACH_JZ4780, &jz4780_chip_info)
+       },
+       {
+               .compatible = "ingenic,x1000-pinctrl",
+               .data = IF_ENABLED(CONFIG_MACH_X1000, &x1000_chip_info)
+       },
+       {
+               .compatible = "ingenic,x1000e-pinctrl",
+               .data = IF_ENABLED(CONFIG_MACH_X1000, &x1000_chip_info)
+       },
+       {
+               .compatible = "ingenic,x1500-pinctrl",
+               .data = IF_ENABLED(CONFIG_MACH_X1500, &x1500_chip_info)
+       },
+       {
+               .compatible = "ingenic,x1830-pinctrl",
+               .data = IF_ENABLED(CONFIG_MACH_X1830, &x1830_chip_info)
+       },
+       { /* sentinel */ },
 };
 
 static struct platform_driver ingenic_pinctrl_driver = {
-- 
2.29.2

Reply via email to