On 17-12-07 11:57, Ingo Molnar wrote:
thanks Rene! I've added your patch to x86.git. I changed a few things
ontop of it, see the additional changelog and delta patch below.
"appropriated it", more. Definitely not going to forgive you for deleting
that comment.
void native_io_delay(void)
{
- io_delay();
+ switch (io_delay_type) {
That's the clumsy bit. native_io_delay() used to be an inline outb, now it's
a switch. Yes, sure, versus an indirect call it's not actually worse, except
as an uglification.
-#ifndef CONFIG_UDELAY_IO_DELAY
-static int __init dmi_alternate_io_delay_port(const struct dmi_system_id *id)
+static int __init dmi_io_delay_0xed_port(const struct dmi_system_id *id)
{
- printk(KERN_NOTICE "%s: using alternate I/O delay port\n", id->ident);
- io_delay = alternate_io_delay;
+ printk(KERN_NOTICE "%s: using 0xed I/O delay port\n", id->ident);
+ io_delay_type = CONFIG_IO_DELAY_TYPE_0XED;
+
return 0;
}
This isn't correct. DMI shouldn't override the CONFIG choice or someone with
matching DMI will have a defective CONFIG option. That's why I put all of it
inside #ifndef.
Rene.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
