Hi, On Sat, Dec 12, 2020 at 9:29 PM Stephen Boyd <swb...@chromium.org> wrote: > > We don't need to force this to be trigger high here, as the firmware > properly configures the irq flags already. Drop it to save a line. > > Cc: Douglas Anderson <diand...@chromium.org> > Cc: Rajendra Nayak <rna...@codeaurora.org> > Cc: Mukesh Kumar Savaliya <msava...@codeaurora.org> > Cc: Akash Asthana <akash...@codeaurora.org> > Signed-off-by: Stephen Boyd <swb...@chromium.org> > --- > drivers/spi/spi-qcom-qspi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/spi/spi-qcom-qspi.c b/drivers/spi/spi-qcom-qspi.c > index 5eed88af6899..8e70f5e63e0b 100644 > --- a/drivers/spi/spi-qcom-qspi.c > +++ b/drivers/spi/spi-qcom-qspi.c > @@ -516,8 +516,7 @@ static int qcom_qspi_probe(struct platform_device *pdev) > ret = platform_get_irq(pdev, 0); > if (ret < 0) > goto exit_probe_master_put; > - ret = devm_request_irq(dev, ret, qcom_qspi_irq, > - IRQF_TRIGGER_HIGH, dev_name(dev), ctrl); > + ret = devm_request_irq(dev, ret, qcom_qspi_irq, 0, dev_name(dev), > ctrl);
I don't feel that the old code is really wrong, but I guess it is weird that it's double-specified (both in the code and in the dts). ...so this is OK w/ me. Reviewed-by: Douglas Anderson <diand...@chromium.org>
