On Tue, Dec 15, 2020 at 8:36 AM Enrico Weigelt, metux IT consult
<i...@metux.net> wrote:
>
> * drivers/nvdimm/core.c doesn't use anything from badblocks.h on its own,
> thus including it isn't needed. There's indeed indirect use, via funcs
> in nd.h, but this one already includes badblocks.h.
>
> * drivers/nvdimm/claim.c calls stuff from badblocks.h and therefore should
> include it on its own (instead of relying any other header doing that)
>
> * drivers/nvdimm/btt.h doesn't really need anything from badblocks.h and
> can easily live with a forward declaration of struct badblocks (just having
> pointers to it, but not dereferencing it anywhere)
Thanks, looks ok to me.
It was commit aa9ad44a42b4 ("libnvdimm: move poison list functions to
a new 'badrange' file") that left the straggling include in core.c.
