On Thu, Dec 17, 2020 at 10:28 AM Calvin Johnson
<[email protected]> wrote:
> On Tue, Dec 15, 2020 at 07:28:10PM +0200, Andy Shevchenko wrote:
> > On Tue, Dec 15, 2020 at 6:44 PM Calvin Johnson
> > <[email protected]> wrote:
...
> > > + if (sscanf(cp, "ethernet-phy-id%4x.%4x", &upper, &lower) == 2) {
> > *phy_id = ((upper & 0xFFFF) << 16) | (lower & 0xFFFF);
> > And perhaps GENMASK() ?
>
> Sure. Will rewrite accordingly.
Reading this again I'm now not sure these masks are needed at all.
--
With Best Regards,
Andy Shevchenko
