On Thu, Dec 17, 2020 at 11:45:56AM +0100, Peter Zijlstra wrote: > On Wed, Dec 16, 2020 at 02:01:58PM -0600, Josh Poimboeuf wrote: > > So this is kind of tricky, because the unreachable() annotation usually > > means "the previous instruction is a dead end". Most of the time, the > > next instruction -- the one actually pointed to by the annotation -- is > > actually reachable from another path. > > *groan*, this is why I ended up sticking a nop in > instrumentation_begin()/_end().
Oh yeah, I forgot about that. That would be another option if my patch doesn't work out. /me grumbles something about integrating objtool with compiler plugins someday... -- Josh
