From: Wang ShaoBo <bobo.shaobow...@huawei.com>

[ Upstream commit b96f038432362a20b96d4c52cefeb2936e2cfd2f ]

Make cpufreq_online() return negative error codes on all errors that
cause the policy to be destroyed, as appropriate.

Signed-off-by: Wang ShaoBo <bobo.shaobow...@huawei.com>
[ rjw: Subject and changelog edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wyso...@intel.com>
Signed-off-by: Sasha Levin <sas...@kernel.org>
---
 drivers/cpufreq/cpufreq.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 194a6587a1de1..1178ac323a9e0 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1384,8 +1384,10 @@ static int cpufreq_online(unsigned int cpu)
 
                policy->min_freq_req = kzalloc(2 * 
sizeof(*policy->min_freq_req),
                                               GFP_KERNEL);
-               if (!policy->min_freq_req)
+               if (!policy->min_freq_req) {
+                       ret = -ENOMEM;
                        goto out_destroy_policy;
+               }
 
                ret = freq_qos_add_request(&policy->constraints,
                                           policy->min_freq_req, FREQ_QOS_MIN,
@@ -1422,6 +1424,7 @@ static int cpufreq_online(unsigned int cpu)
        if (cpufreq_driver->get && has_target()) {
                policy->cur = cpufreq_driver->get(policy->cpu);
                if (!policy->cur) {
+                       ret = -EIO;
                        pr_err("%s: ->get() failed\n", __func__);
                        goto out_destroy_policy;
                }
-- 
2.27.0

Reply via email to