On Wed, Dec 23, 2020 at 10:54:26AM -0700, Rob Herring wrote: > On Mon, Dec 21, 2020 at 11:39 PM Sam Ravnborg <s...@ravnborg.org> wrote: > > > > Hi Rob, > > > > On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote: > > > 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is > > > preferred for a single entry while greater than 1 should have an 'items' > > > list. > > > > > > A meta-schema check for this is pending once these existing cases are > > > fixed. > > > > > > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > > > Cc: Vinod Koul <vk...@kernel.org> > > > Cc: Mark Brown <broo...@kernel.org> > > > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > > > Cc: Jassi Brar <jaswinder.si...@linaro.org> > > > Cc: dri-de...@lists.freedesktop.org > > > Cc: dmaeng...@vger.kernel.org > > > Cc: alsa-de...@alsa-project.org > > > Cc: linux-...@vger.kernel.org > > > Signed-off-by: Rob Herring <r...@kernel.org> > > > > With one comment below, > > Acked-by: Sam Ravnborg <s...@ravnborg.org> > > > > > --- > > > diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > > > b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > > > index 737c1f47b7de..54c361d4a7af 100644 > > > --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > > > +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml > > > @@ -74,11 +74,8 @@ properties: > > > > > > phys: > > > maxItems: 1 > > > - items: > > > - - description: phandle + phy specifier pair. > > > > The description may help some people, so keeping the > > description and deleting maxItems would maybe be better. > > Do we really want to describe 'phys' hundreds of times? No. The > question I ask on the descriptions is could it be generated instead.
I agree. If the description had mentioned why particular PHY was referenced, I would have kept that, but "the phy is a phy" is probably not something we want to duplicate everywhere. -- Regards, Laurent Pinchart
