From: Christophe JAILLET <christophe.jail...@wanadoo.fr>

[ Upstream commit 4375ada01963d1ebf733d60d1bb6e5db401e1ac6 ]

If the 'register_netdev()' call fails, we must undo a previous
'bcmgenet_mii_init()' call.

Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file")
Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr>
Acked-by: Florian Fainelli <f.faine...@gmail.com>
Link: 
https://lore.kernel.org/r/20201212182005.120437-1-christophe.jail...@wanadoo.fr
Signed-off-by: Jakub Kicinski <k...@kernel.org>
Signed-off-by: Sasha Levin <sas...@kernel.org>
---
 drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c 
b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
index 5d4189c94718c..2921ae13db283 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
@@ -3433,8 +3433,10 @@ static int bcmgenet_probe(struct platform_device *pdev)
        clk_disable_unprepare(priv->clk);
 
        err = register_netdev(dev);
-       if (err)
+       if (err) {
+               bcmgenet_mii_exit(dev);
                goto err;
+       }
 
        return err;
 
-- 
2.27.0



Reply via email to