[PATCH 2/3] thermal: ti-soc-thermal: Simplify polling with iopoll

[Tony Lindgren]

We can use iopoll for checking the EOCZ (end of conversion) bit.

Cc: Adam Ford <aford...@gmail.com>
Cc: Carl Philipp Klemm <phil...@uvos.xyz>
Cc: Eduardo Valentin <edubez...@gmail.com>
Cc: Merlijn Wajer <merl...@wizzup.org>
Cc: Pavel Machek <pa...@ucw.cz>
Cc: Peter Ujfalusi <peter.ujfal...@gmail.com>
Cc: Sebastian Reichel <s...@kernel.org>
Signed-off-by: Tony Lindgren <t...@atomide.com>
---
 drivers/thermal/ti-soc-thermal/ti-bandgap.c | 30 ++++++++++-----------
 1 file changed, 14 insertions(+), 16 deletions(-)

diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c 
b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
--- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c
+++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
@@ -15,7 +15,6 @@
 #include <linux/kernel.h>
 #include <linux/interrupt.h>
 #include <linux/clk.h>
-#include <linux/delay.h>
 #include <linux/gpio/consumer.h>
 #include <linux/platform_device.h>
 #include <linux/err.h>
@@ -27,6 +26,7 @@
 #include <linux/of_platform.h>
 #include <linux/of_irq.h>
 #include <linux/io.h>
+#include <linux/iopoll.h>
 #include <linux/cpu_pm.h>
 #include <linux/device.h>
 #include <linux/pm_runtime.h>
@@ -603,8 +603,9 @@ void *ti_bandgap_get_sensor_data(struct ti_bandgap *bgp, 
int id)
 static int
 ti_bandgap_force_single_read(struct ti_bandgap *bgp, int id)
 {
-       u32 counter = 1000;
        struct temp_sensor_registers *tsr;
+       int error;
+       u32 val;
 
        /* Select continuous or single conversion mode */
        if (TI_BANDGAP_HAS(bgp, CONT_MODE_ONLY))
@@ -615,27 +616,24 @@ ti_bandgap_force_single_read(struct ti_bandgap *bgp, int 
id)
        /* Start of Conversion = 1 */
        RMW_BITS(bgp, id, temp_sensor_ctrl, bgap_soc_mask, 1);
 
-       /* Wait for EOCZ going up */
        tsr = bgp->conf->sensors[id].registers;
 
-       while (--counter) {
-               if (ti_bandgap_readl(bgp, tsr->temp_sensor_ctrl) &
-                   tsr->bgap_eocz_mask)
-                       break;
-               udelay(1);
-       }
+       /* Wait for EOCZ going up */
+       error = readl_poll_timeout_atomic(bgp->base + tsr->temp_sensor_ctrl,
+                                         val, val & tsr->bgap_eocz_mask,
+                                         1, 1000);
+       if (error)
+               dev_warn(bgp->dev, "eocz timed out waiting high\n");
 
        /* Start of Conversion = 0 */
        RMW_BITS(bgp, id, temp_sensor_ctrl, bgap_soc_mask, 0);
 
        /* Wait for EOCZ going down */
-       counter = 1000;
-       while (--counter) {
-               if (!(ti_bandgap_readl(bgp, tsr->temp_sensor_ctrl) &
-                     tsr->bgap_eocz_mask))
-                       break;
-               udelay(1);
-       }
+       error = readl_poll_timeout_atomic(bgp->base + tsr->temp_sensor_ctrl,
+                                         val, !(val & tsr->bgap_eocz_mask),
+                                         1, 1000);
+       if (error)
+               dev_warn(bgp->dev, "eocz timed out waiting low\n");
 
        return 0;
 }
-- 
2.29.2