Re: [PATCH v7 1/5] counter: Internalize sysfs interface code

[David Lechner]

On 12/25/20 6:15 PM, William Breathitt Gray wrote:

diff --git a/drivers/counter/ti-eqep.c b/drivers/counter/ti-eqep.c
index a60aee1a1a29..6c058b93dc98 100644
--- a/drivers/counter/ti-eqep.c
+++ b/drivers/counter/ti-eqep.c

-static ssize_t ti_eqep_position_floor_write(struct counter_device *counter,
-                                           struct counter_count *count,
-                                           void *ext_priv, const char *buf,
-                                           size_t len)
+static int ti_eqep_position_floor_write(struct counter_device *counter,
+                                       struct counter_count *count, u64 floor)
  {
        struct ti_eqep_cnt *priv = counter->priv;
-       int err;
-       u32 res;

- err = kstrtouint(buf, 0, &res);

-       if (err < 0)
-               return err;
+       if (floor != (u32)floor)
+               return -ERANGE;

- regmap_write(priv->regmap32, QPOSINIT, res);

+       regmap_write(priv->regmap32, QPOSINIT, floor);

- return len;

+       return 0;
  }

This will conflict with 2ba7b50893de "counter:ti-eqep: remove floor"
(in Jonathan's fixes-togreg branch) which removes these functions.