Hi Martin,
Martin Blumenstingl <martin.blumensti...@googlemail.com> wrote on Mon,
4 Jan 2021 14:13:04 +0100:
> Hi Miquel,
>
> thank you for looking into this
>
> On Mon, Jan 4, 2021 at 9:48 AM Miquel Raynal <miquel.ray...@bootlin.com>
> wrote:
> [...]
> > > nand_set_flash_node(&ebu_host->chip, dev->of_node);
> > > - if (!mtd->name) {
> > > - dev_err(ebu_host->dev, "NAND label property is
> > > mandatory\n");
> > > - return -EINVAL;
> > > - }
> >
> > This is valid code, it's best to use a label = "my-storage"; property
> > in your NAND DT node. Then mtd->name will be updated by
> > nand_set_flash_node().
> so you suggest moving the check instead?
> the original code flow was:
> mtd = NULL;
> if (!mtd->name)
> return -EINVAL;
> mtd = nand_to_mtd(&ebu_host->chip);
> ...
>
> by saying that the code itself is valid you're asking me to update the
> flow to the following:
> mtd = nand_to_mtd(&ebu_host->chip);
> if (!mtd->name)
> return -EINVAL;
I actually missed the fact that mtd was used initialized, but yes that
is exactly what I meant!
Thanks,
Miquèl
