Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.

Signed-off-by: Srinivas Neeli <srinivas.ne...@xilinx.com>
---
Changes in V4:
-New patch
---
 drivers/gpio/gpio-xilinx.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
index be539381fd82..d010a63d5d15 100644
--- a/drivers/gpio/gpio-xilinx.c
+++ b/drivers/gpio/gpio-xilinx.c
@@ -357,11 +357,8 @@ static int xgpio_probe(struct platform_device *pdev)
        }
 
        chip->clk = devm_clk_get_optional(&pdev->dev, NULL);
-       if (IS_ERR(chip->clk)) {
-               if (PTR_ERR(chip->clk) != -EPROBE_DEFER)
-                       dev_dbg(&pdev->dev, "Input clock not found\n");
-               return PTR_ERR(chip->clk);
-       }
+       if (IS_ERR(chip->clk))
+               return dev_err_probe(&pdev->dev, PTR_ERR(chip->clk), "input 
clock not found.\n");
 
        status = clk_prepare_enable(chip->clk);
        if (status < 0) {
-- 
2.7.4

Reply via email to