On 01/11/21 15:04, Peter Zijlstra wrote: > On Mon, Jan 04, 2021 at 06:26:42PM +0000, Qais Yousef wrote: > > > So I have a proper patch for that now, that actually turned out to be really > > tiny once you untangle exactly what is missing. > > > > Peter, bpf programs aren't considered ABIs AFAIK, do you have concerns about > > that? > > In order to use these you need to rely on BTF to get anything useful > done right? And anything that relies on BTF cannot be ABI.
Yes. To decode struct rq for instance one has to either hardcode it in their program or use BTF to get the definition dynamically. The worry is if we modify the function signature of the tracepoint. Alexei did confirm this can't be an ABI and I'm adding additional documentation to make this crystal clear. Thanks -- Qais Yousef
